Comments on: Smart link plugin for WordPress, beta

By: Denis de Bernardy

Denis de Bernardy — Thu, 02 Jun 2005 10:15:31 +0000

@Monkeypup — I'll check it out when I'll add the affiliate ID.

By: monkeypup

monkeypup — Thu, 02 Jun 2005 01:45:04 +0000

Denis-
Hate to bother you, since you were nice enough to add an Amazon function to the plugin, but I noticed that the Amazon link takes you to a book search, rather than an overall Amazon search. Is it possible to change this? Just curious. I find I get more use out of this plugin everyday. Still the best plugin around.
Thanks!
MP

By: Denis de Bernardy

Denis de Bernardy — Mon, 30 May 2005 15:39:58 +0000

Still… A more reasonable option would have been something like:

$post = apply_filters('post_meta', $post);

or even:

$post->apply_filters('post_meta');

By: Martin Geisler

Martin Geisler — Mon, 30 May 2005 14:45:42 +0000

@Denis: Yes, well, it seems very open-ended: you just attach some code to a hook, and then do what you want. But at the same time it's limited because you have to rely on the right things to be in score when your hook is executed. So without careful planning, you end up having a needed variable be inaccessible from a plugin.

By: Denis de Bernardy

Denis de Bernardy — Mon, 30 May 2005 13:59:17 +0000

@Martin: As much as I like it, I really find the WP plugin system completely broken. Thanks for the fix.

By: Martin Geisler

Martin Geisler — Mon, 30 May 2005 13:46:53 +0000

@Denis: Sorry about the wait — I've now tested your plugin with the standard Kubrick theme (without the nested-comments plugin) and your change isn't quite enough to make it work.

Instead one has to do

$GLOBALS['comments'] = $comments;

for there are actually no global `$comments` variable at all. The above creates it and gives it the right value. Maybe one should use `=&` instead, but I find that construct very annoying so I left it out.

By: philippe

philippe — Mon, 30 May 2005 13:11:24 +0000

salut bernard,
ne parlons pas du non d'hier. ici berlin, comme partout, les francais expatriés ont voté massivement oui…
aurais-tu une doc en francais sur ce plugin, mon anglais laisse un peu désirer.
a+
philippe

By: Denis de Bernardy

Denis de Bernardy — Tue, 24 May 2005 12:52:30 +0000

@Monkeypup: I've a login on the plugin blog, but I've yet to register as a competing plugin author. But I imagine I'll give it a shot. :)

@Martin: Could you check if declaring the following at the beginning of the comment loop solves the problem?

global $comments;

By: monkeypup

monkeypup — Tue, 24 May 2005 11:54:27 +0000

Oh, one other thing. If this doesn't win the Wordpress Plugin competition (you have entered it, right?), something is wrong with the world.

By: monkeypup

monkeypup — Tue, 24 May 2005 11:52:54 +0000

Hey, thanks for throwing in the Amazon link function. As always, you rock, Denis.